Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for the client certificate verification #1812

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

pooneh-m
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
To help with debugging if there is a client certificate verification failure

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

Add logging for the client certificate verification.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d8cb14c9-58ae-4718-97c5-5d875418554b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 23b60be into master Sep 14, 2020
@aLekSer
Copy link
Collaborator

aLekSer commented Sep 14, 2020

One of two builds fired for this PR succeeded https://console.cloud.google.com/cloud-build/builds/1d8e340a-2463-4bd8-a72c-c95917378d0d?project=agones-images
But Bot does not add Success message to this PR for some reason.

@aLekSer aLekSer deleted the pooneh-m-patch-2 branch September 14, 2020 08:58
@aLekSer aLekSer added the area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc label Sep 14, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 22, 2020
@markmandel markmandel added the kind/feature New features for Agones label Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Add logging for the client certificate verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/feature New features for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants